fix(exports): support default-only module shape in ESM wrapper#72
Conversation
Summary of ChangesHello @BleedingDev, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses an issue where the ESM wrapper for Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request effectively resolves an ESM wrapper issue by transitioning from createRequire to a direct ESM import, complemented by robust fallback logic to accommodate various module export structures. This is a great improvement for compatibility with different JavaScript runtimes like Bun. The inclusion of a targeted regression test for the default-only export scenario is a strong addition that validates the fix. I have one suggestion regarding the new test file to enhance its readability.
2 participants
Summary
createRequire(...).require('../dist/index.js')inexports/index.mjswith an ESM import.ReactRefreshRspackPlugin)default)Why
In strict Bun mode, the ESM wrapper path can surface a default-only module shape where destructuring a named export is undefined.
This causes
import DefaultExport, { ReactRefreshRspackPlugin } from '@rspack/plugin-react-refresh'to break depending on runtime/module interop shape.This change keeps Node behavior intact while making the ESM wrapper resilient across runtime interop differences.
Validation
pnpm lintpnpm testbun --bun -e "import DefaultExport, { ReactRefreshRspackPlugin } from './exports/index.mjs'; const a = new DefaultExport(); const b = new ReactRefreshRspackPlugin(); console.log(a.options.reactRefreshLoader && b.options.reactRefreshLoader ? 'ok' : 'bad');"All pass locally.
Maintainer Question
If you prefer a narrower compatibility target for wrapper export resolution, I can adjust the normalization logic accordingly.